Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing condition for rendering overlay #4515

Merged
merged 5 commits into from
Jan 2, 2024
Merged

Fixing condition for rendering overlay #4515

merged 5 commits into from
Jan 2, 2024

Conversation

galvana
Copy link
Contributor

@galvana galvana commented Dec 14, 2023 •
edited
Loading

Description Of Changes

Adding an additional condition to check for the value of showBanner before rendering the banner overlay.

Code Changes

  • Updated Overlay.tsx

Steps to Confirm

  • Set FIDES_PRIVACY_CENTER__PREVENT_DISMISSAL=true on Privacy Center container
  • Load Cookie House sample app in any location with a notice, e.g. http://localhost:3000/?geolocation=FR-IDG
  • See the opt-in banner and confirm that dismissal is prevented and background overlay prevents clicks
  • Click “Accept All” to save preferences, confirm that the banner is dismissed and background overlay disappears
  • Reload the page as a returning visitor
  • Confirm that the banner no longer displays and that the background overlay doesn't appear

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

@vercel Vercel
Copy link

vercel bot commented Dec 14, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2024 6:18pm

@cypress Cypress
Copy link

cypress bot commented Dec 14, 2023 •
edited
Loading

Passing run #5798 ↗︎

0 4 0 0 Flakiness 0

Details:

Merge 0917fc9 into b64133f...
Project: fides Commit: 577ffe6ecf ℹ️
Status: Passed Duration: 00:32 💡
Started: Jan 2, 2024 6:26 PM Ended: Jan 2, 2024 6:27 PM

Review all test suite changes for PR #4515 ↗︎

@galvana galvana marked this pull request as ready for review December 14, 2023 20:22
Kelsey-Ethyca
Kelsey-Ethyca approved these changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@Kelsey-Ethyca Kelsey-Ethyca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

embed looks good now
Screenshot 2024-01-02 at 10 30 58 AM

@galvana galvana merged commit 2b520e9 into main Jan 2, 2024
13 checks passed
@galvana galvana deleted the PROD-1534-hide-blocking-overlay-on-return branch January 2, 2024 19:03
galvana added a commit that referenced this pull request Jan 2, 2024
@galvana
Fixing condition for rendering overlay (#4515)
f8824cf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kelsey-Ethyca Kelsey-Ethyca Kelsey-Ethyca approved these changes

@NevilleS NevilleS Awaiting requested review from NevilleS

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@galvana @Kelsey-Ethyca